Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tweak installation language in toolchain install #4811

Merged
merged 1 commit into from
Jul 4, 2024
Merged

Conversation

charliermarsh
Copy link
Member

Summary

Like #4808 but with a few more changes. I suspect this will require some bikeshedding but I find the use of "installation" and "installed" in the same sentence to be kind of a lot.

@charliermarsh charliermarsh requested a review from zanieb July 4, 2024 17:22
@charliermarsh charliermarsh added cli Related to the command line interface preview Experimental behavior labels Jul 4, 2024
Copy link
Member

@zanieb zanieb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah this is great, thank you

@charliermarsh charliermarsh merged commit a13ab43 into main Jul 4, 2024
47 checks passed
@charliermarsh charliermarsh deleted the charlie/py branch July 4, 2024 21:05
@@ -88,26 +88,23 @@ pub(crate) async fn install(
if matches!(requests.as_slice(), [PythonRequest::Any]) {
writeln!(
printer.stderr(),
"A installation is already installed. Use `uv installation install <request>` to install a specific installation.",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Damn.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cli Related to the command line interface preview Experimental behavior
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants